Net::HTTP.post_form() is broken.

[rob@…]

I'm running the latest nightly(05/05/2010), to reproduce:

require 'net/http'
Net::HTTP.post_form(URI.parse('http://www.google.com/foobar', { :foo => 'bar' })

# ... Produces:
ArgumentError: method `force_encoding:' does not work on NSStrings

Thanks.

[rob@…]

Replying to rob@…:

I'm running the latest nightly(05/05/2010), to reproduce: {{{ require 'net/http' Net::HTTP.post_form(URI.parse(' http://www.google.com/foobar', { :foo => 'bar' }) # ... Produces: ArgumentError: method `force_encoding:' does not work on NSStrings }}} Thanks.

Syntax error in the last demo, should be:

require 'net/http'
Net::HTTP.post_form(URI.parse('http://www.google.com/foobar'), { :foo => 'bar' })

# ... Produces:
ArgumentError: method `force_encoding:' does not work on NSStrings

[bricollins@…]

I've attached a patch, it uses the native NSString percent escaping instead of that ugly regex. However we don't know if NSUTF8StringEncoding is defined when net/http is required so there is an ugly one liner to define it as 4 otherwise. I've no doubt lsansonetti will figure out a better way.

[bricollins@…]

Cc Me!

[bricollins@…]

Better version uploaded

[lsansonetti@…]

This was simply a bug in net/http.rb that was fixed upstream in 1.9, #to_s wasn't called on keys on the given hash. I backported the latest version in r4083 and the snippet now works.