Projects

Ticket #190 (closed enhancement: fixed)

Opened 3 years ago

Last modified 14 months ago

Easily checking the upstream ruby svn revision.

Reported by: eloy.de.enige@… Owned by: lsansonetti@…
Priority: major Milestone: MacRuby 0.5
Component: MacRuby Keywords:
Cc:

Description

It would be a good thing imo if there was an easy way to check the revision of the upstream Ruby that the current MacRuby trunk is based on.

Ruby itself contains a RUBY_REVISION constant, but it's 0 for some reason. Maybe it would be an idea to make that work again?

It's important because people should be able to easily check whether or not a something works on a vanilla Ruby of the same revision as MacRuby, before creating tickets etc.

Attachments

0001-Properly-read-the-git-revision.patch Download (1.4 KB) - added by vincent.isambart@… 3 years ago.
Get the correct revision from git when the head is detached

Change History

Changed 3 years ago by vincent.isambart@…

I already did it (commited by Laurent in revision 766), and it's available in the MACRUBY_REVISION constant. My patch even works with git (the git version on the trunk does not work correctly if the head is detached, but I already sent a patch to Laurent to fix it).

Changed 3 years ago by eloy.de.enige@…

Hey Vincent,

I'm aware of the change you mean, but that is to keep track of the MacRuby revision. What I want to be able to check is the revision of upstream Ruby that the current MacRuby is based on. At the moment I have no idea which Ruby 1.9 revision Laurent merged the last time, so it's very hard to check if a certain library runs on vanilla Ruby and was introduced by MacRuby.

This makes efficient bug reporting very hard.

- Eloy

PS: Did you send the patch to Laurent privately? Otherwise I can commit it too.

Changed 3 years ago by vincent.isambart@…

Get the correct revision from git when the head is detached

Changed 3 years ago by vincent.isambart@…

Sorry, read the message too quickly :P

The Ruby version MacRuby is based on is given by macruby -v: MacRuby version 0.4 (ruby 1.9.0 2008-06-03) [universal-darwin9.0, x86_64]

Looking at the history of the 1.9 repository, it seems to be between the revisions 16761 and 16799 of the Ruby repository.

For the small patch, I just attached it. Feel free to commit it when you have time.

Changed 14 months ago by vincent.isambart@…

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to MacRuby 0.5
Note: See TracTickets for help on using tickets.